Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't zero out 'Show Mirrors' flag when writing 'Show Pilot Model' flag. #98

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

arithex
Copy link
Collaborator

@arithex arithex commented Jun 20, 2023

NOT TESTED .. just a quick and dirty PR for sake of discussion.

Issue => #97

Q: Do we want to do a quick, surgical fix.. or should we reconsider whether AL should duplicate all of these "green checkbox" config options in the pop file .. smart scaling, pilot model, etc?

I don't fully understand the original rationale, for duplicating these in AL. (It seems like the only thing AL needed to write in the pop file is the path to the key file.)

But I also don't know enough of current plan and state of 4.38 development, to have an opinion -- viz. is new work being done on the BMS 2d experience? or is the strategy to migrate more of the UI for those various Graphics/Sound/Simulation settings (and cfg file settings) into AL?

@chihirobelmo
Copy link
Owner

chihirobelmo commented Jun 20, 2023

Q: Do we want to do a quick, surgical fix.. or should we reconsider whether AL should duplicate all of these "green checkbox" config options in the pop file .. smart scaling, pilot model, etc?
I don't fully understand the original rationale, for duplicating these in AL. (It seems like the only thing AL needed to write in the pop file is the path to the key file.)

well, I thought those options in the Falcon UI or in the CFG file looked easy to miss for new users though I think those are unique features of BMS... that's why I added them to AL. Maybe I can just enable them by default or make them more appealing in Falcon UI instead in the future.

But I also don't know enough of current plan and state of 4.38 development, to have an opinion -- viz. is new work being done on the BMS 2d experience? or is the strategy to migrate more of the UI for those various Graphics/Sound/Simulation settings (and cfg file settings) into AL?

a new way of the config file has been discussed for a short time... but no one has started to code yet. for now, this quick fix should be okay but ideally, I want BMS a new Falcon config file that can be editable by a user but also UI can save the status...

@chihirobelmo
Copy link
Owner

thx for the fix!

@chihirobelmo chihirobelmo marked this pull request as ready for review August 19, 2023 13:02
@chihirobelmo chihirobelmo merged commit b5d1b4b into chihirobelmo:develop Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants