Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-game graphics settings for "Show Mirrors" is overwritten each launch #97

Closed
arithex opened this issue Jun 14, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@arithex
Copy link
Collaborator

arithex commented Jun 14, 2023

https://forum.falcon-bms.com/post/375958

4.37 added a new option for "mirrors", but there's no corresponding checkbox in Alt Launcher, so it gets zeroed each launch.

I would propose: AL shouldn't duplicate and overwrite all those pop file options -- we should surgically update what we need to.

I can submit a PR for that, if helpful.

@chihirobelmo chihirobelmo self-assigned this Jun 18, 2023
@chihirobelmo
Copy link
Owner

thx, I'd like to have your PR.

something I feel strange is that AL reads the binary file for option, changes only corresponding bytes, and overwrites. so, if AL does not have a checkbox for options, it should remain as set by BMS UI...but I also have to look into it.

@arithex
Copy link
Collaborator Author

arithex commented Jun 20, 2023

Draft PR for discussion => #98

That's the quick-fix. I feel like the "right" long-term fix is either (a) add a proper checkbox for 'Show Mirrors' alongside 'Pilot Model' et al .. or (b) remove all the duplicated settings (if BMS 2d Setup UI is not dead code).

chihirobelmo added a commit that referenced this issue Aug 19, 2023
* Don't zero out 'Show Mirrors' flag when writing 'Show Pilot Model' flag.

* Fix for issue-99.. (1) wait for bms-logcat.exe process to complete, and (2) update the Callsign.pop file bits, generated for new callsigns, to match what 4.37 expects.

---------

Co-authored-by: arithex <arithex@users.noreply.github.com>
Co-authored-by: chihirobelmo <32677587+chihirobelmo@users.noreply.github.com>
@arithex arithex closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants