This repository has been archived by the owner on Mar 29, 2019. It is now read-only.
Begin Rails 3 work #256
Closed
Begin Rails 3 work #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesome_nested_set would have needed to be updated for rails 3.1, unvendoring it makes updates easier. The patches to the vendored awesome_nested_set will have to be reviewed and adapted.
…df plugin (#4796) ActionView::TemplateHandlers is deprecated on Rails3.2 and Redmine cannot boot on Rails3.2. Redmine does not use this rfpdf plugin feature. git-svn-id: svn://rubyforge.org/var/svn/redmine/trunk@8702 e93f8b46-1217-0410-a6f0-8f06a7374b81
Original code by Jean-Philippe Lang redmine:b590ff105e2e69ccd5b06c2783860e78bc1b392b
…dlers. git-svn-id: svn://rubyforge.org/var/svn/redmine/trunk@9604 e93f8b46-1217-0410-a6f0-8f06a7374b81
The bundled open_id_authentication plugin has some Rails 3 incompatibilities.
Use class_attribute instead
As partials might also be used in js formatted responses, we just rename them to .erb. Normal templates are renamed to .html.erb. This follows the new Rails convention to play well with tilt. for i in `find app/views/**/_*.rhtml`; do \ git mv $i `echo $i | sed s/\\.rhtml$/.erb/`; \ done for i in `find app/views/**/*.rhtml`; do \ git mv $i `echo $i | sed s/\\.rhtml$/.html.erb/`; \ done
This is required to work around a circular dependency issue during class loading. See the comment in application.rb for details.
Rails 3 uses a secret token in various places. The former cookie secret has thus been re-purposed to a generic secret token which is generated with the new task. The former task also configured the cookie session store. this is now done in application.rb and can be overridden in the additional_environment.rb
|
I disagree this pull request. You should use rebase as we did in Redmine. |
|
@marutosi this is a rebase of the porting work on unstable and won't be merged as one big commit but as it is, I'm sorry but I'm not sure I understand the objection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines some Rails 3 work from @meineerde and me, this is a beginning but still needs a lot of work and is far from stable.
Current Ruby and Rails status: The current targets are Ruby 1.9.3 (1.8 is EOL) and Rails 3.2-latest. Ruby support can be expanded to later Ruby versions once it's stable on 1.9.3.