Skip to content
This repository has been archived by the owner. It is now read-only.

[V2] Rails 3.1 porting #306

Closed
wants to merge 163 commits into from

Conversation

Projects
None yet
@marutosi
Copy link
Contributor

commented Jul 20, 2013

New version of #300.

goncalossilva and others added some commits May 27, 2010

Rails3.1: lib: replace "ActionController::UrlWriter" to "Rails.applic…
…ation.routes.url_helpers"

--HG--
extra : source : 3053a4d2820d02ca4efd1fc9352b4225edd31710
[#269] Removing obsolete require 'tree' - this is done by config/envi…
…ronment.rb

--HG--
extra : source : 3fe2648e23c265e3180395ccf0b55168a8a55778
Toshi MARUYAMA
Rails3: delete engines plugin
--HG--
extra : source : fbb0c08aa5993d310e848de61f2a9b93e218bbf9
Toshi MARUYAMA
Rails3: extra: remove unused files.
--HG--
extra : source : 624d2b498d6b06966225579c56d3885bd656d803
Toshi MARUYAMA
Rails3: config/environments and boot.rb
--HG--
extra : source : 8e03b160eb52a5f1e77cb0816fe136e6d93434b3
Toshi MARUYAMA
Rails3: add Rails3 files (#4796)
--HG--
extra : source : d5e904671ebb5f1705aacc9488bfaf77cdc28572
Toshi MARUYAMA
Rails3: Gemfile: use Rails 3.0
--HG--
extra : source : 5de973de532c6af93ec7477ff0ef701153954683
Toshi MARUYAMA
Rails3: Rakefile
--HG--
extra : source : 35b1a3ae9e65e36c97b5112afb1f617e9b76b50d
Toshi MARUYAMA
Rails3: config/initializers/*
--HG--
extra : source : ee8efc8b49b04838b989e27e79359c30aa3ef090
Toshi MARUYAMA
Rails3: require 'rails/source_annotation_extractor' at lib/tasks/plug…
…ins.rake

--HG--
extra : source : 2ade0e29cbefe9688847def54018d3900f7991bf
Toshi MARUYAMA
Rails3: vendor/plugins/prepend_engine_views/init.rb
--HG--
extra : source : e25da5d45bace74c97a273805f414e8e36b502ed
Toshi MARUYAMA
Rails3: test: require 'rails/test_help'
--HG--
extra : source : c048a5f505c19010b1039e1338df30bb1fc4ca91
scm: use ActionView::TestCase instead of HelperTestCase at repository…
…_helper_test.rb.

ActionView::Helpers::ActiveRecordHelper at test/helper_testcase.rb
does not exist on Rails 3.0.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6107 e93f8b46-1217-0410-a6f0-8f06a7374b81

--HG--
extra : source : 83cab88efc7e41242c897dfd908ba1f4f8911567
Toshi MARUYAMA
Rails3: model: replace "named_scope" to "scope"
--HG--
extra : source : 6f76b23aac018814382b6e80159f2513f5a2cf63
Toshi MARUYAMA
Rails3.1: config: comment out "config.action_view.debug_rjs" at confi…
…g/environments/development.rb

$ rake db:migrate RAILS_ENV=development --trace
rake aborted!
undefined method `debug_rjs=' for ActionView::Base:Class
.
.
.
/REDMINE-1/hg-workdir/redmine-rails3-bb/config/environment.rb:5

--HG--
extra : source : ed91c7c0e4b94b12506f4b19551a2a457feb9065
Toshi MARUYAMA
Rails3.1: model: replace "ActionController::UrlWriter" to "Rails.appl…
…ication.routes.url_helpers"

--HG--
extra : source : d5633a9e8c6b4f6462c2461ffd8a563be5d8d2c5
Toshi MARUYAMA
Rails3.1: controller: remove "exempt_from_layout" at application_cont…
…roller.rb

On Rails 3.0:
DEPRECATION WARNING: exempt_from_layout is no longer needed,
because layouts in Rails 3 are restricted to the content-type of the template that was rendered.

--HG--
extra : source : 1eb7ec37583fa5cb3e2d1f3f10ff824fc47f07ce
Toshi MARUYAMA
Rails3.1: controller: comment out "filter_parameter_logging :password"
--HG--
extra : source : 1fe9eb17cd7feb30f913a48571942da5262f46d0
Toshi MARUYAMA
Rails3.1: test: add "require 'shoulda/rails'" at test/test_helper.rb
$ rake test:units

/REDMINE-1/hg-workdir/redmine-rails3-bb/test/unit/project_test.rb:69:
  undefined method `should_validate_presence_of' for ProjectTest:Class (NoMethodError)

--HG--
extra : source : 164d68b15de7d55e8d63b7733d1404134665a2b4
Toshi MARUYAMA
Rails3.1: lib: comment out "include ActionView::Helpers::PrototypeHel…
…per"

--HG--
extra : source : f5b681c32b191e197cde79edc0c3b037db5f3d93
Toshi MARUYAMA
Rails3.1: route: replace ActionController::Routing::Routes.draw
--HG--
extra : source : 17c193814943a7bfded6dd903158c7597861876d
Rails3: test: csv: functional/issues_controller_test.rb
<pre>
Failure:
test_index_csv_export(TimelogControllerTest) [test/functional/timelog_controller_test.rb:325]:
<"text/csv"> expected but was
<"text/csv; header=present">.
</pre>

--HG--
extra : source : f28f3bbc5d292ac62f22574ab92d96f600f5c6be
Rails3: Gemfile: replace vendored awesome_nested_set with the gem
awesome_nested_set would have needed to be updated for rails 3.1,
unvendoring it makes updates easier.
The patches to the vendored awesome_nested_set will have to be reviewed and adapted.

--HG--
extra : source : 224df005aeb75b5dfb02d44f0d6817c8486dcd04
Rails3: Gemfile: The bundled open_id_authentication plugin has some 3…
….1 incompatibilities, moving to Gemfile

<pre>
$ rake db:migrate RAILS_ENV=test --trace
rake aborted!
uninitialized constant OpenIdAuthentication::Railtie::ControllerMethods
/home/xxxxx/.rvm/gems/ruby-1.8.7-p357/gems/open_id_authentication-1.1.0/lib/open_id_authentication.rb:49
</pre>

--HG--
extra : source : c5ae1b17503b655368a864d93af7086a044b04ba
Move open_id_authentication to Gemfile
The bundled open_id_authentication plugin has some Rails 3
incompatibilities.

--HG--
extra : source : 73f1b7d7cc789b198cb102dd2aada238733e7288
Toshi MARUYAMA
Rails3: db migrate: change value of "repositories" table "type" column
The single-table inheritance mechanism failed to locate the subclass: 'child'.
This error is raised because the column 'type' is reserved for storing the class in case of inheritance.
Please rename this column if you didn't intend it to be used for storing the inheritance class
or overwrite Parent.inheritance_column to use another column for that information.
(ActiveRecord::SubclassNotFound)

--HG--
extra : source : ee6b986d30171e9a96f405582f9808fe65659c0e
Toshi MARUYAMA
Rails3: test: fixture: change value of "repositories" table "type" co…
…lumn

The single-table inheritance mechanism failed to locate the subclass: 'child'.
This error is raised because the column 'type' is reserved for storing the class in case of inheritance.
Please rename this column if you didn't intend it to be used for storing the inheritance class
or overwrite Parent.inheritance_column to use another column for that information.
(ActiveRecord::SubclassNotFound)

http://www.42.mach7x.com/2011/07/22/the-single-table-inheritance-mechanism-failed-to-locate-the-subclass/

--HG--
extra : source : 9f698693eb19b4e0b24741eedb0b0af7a7e7bc69
Toshi MARUYAMA
Rails3: view: form_tag: equals sign mandatory to print blocks
--HG--
extra : source : 555954ece398ab6da824b6aed31c489f2c15b6c5
Rails3: view: form_for 2 args
--HG--
extra : source : 0a3ab1411b941839e3bd13da99c7585f3b4d74e5
Toshi MARUYAMA
Rails3.1: vendor: replace "named_scope" to "scope" at vendor/plugins/…
…acts_as_watchable/lib/acts_as_watchable.rb

--HG--
extra : source : 221aad0751853472b5e75815e8477d361dc20e3c

jplang and others added some commits Apr 22, 2012

No need to save journal details.
--HG--
extra : source : db7656646b23dbc8618e5fd29503280f04ffb505
replace object_daddy on unit tests
--HG--
extra : source : e8d1f32cfbb883f502b5747279be98131ba83ab0
replace object_daddy on ApiTest::UsersTest
--HG--
extra : source : beee601eb0cf07ff07404467bc5ea3ea06c3984f
replace object_daddy at test/integration/layout_test.rb
--HG--
extra : source : 7021e6e9813efa1360f5e7ac07b057912921bd69
replace object_daddy on functional tests
--HG--
extra : source : 10560dcc4980cffcbcf490f9cac8691c5f9e47dd
replace object_daddy on 'should return issues matching a given id' of…
… AutoCompletesControllerTest

--HG--
extra : source : 1a908eb709e25c40468495f234b73321d8ee5cc5
replace object_daddy on AutoCompletesControllerTest
--HG--
extra : source : bbbf90fe55658fda71d4b10689b2569469e9bc10
Removed some generate! calls.
--HG--
extra : source : e077a01d3579a41e2dd370bbb316a8fd91fe4eae
fix creation of journals in order to fix some tests
--HG--
extra : source : 929506efc0cf53e62a749f38bf6b32b966a5aeb2
remove object_daddy from tests
--HG--
extra : source : 7adabe9800c8cf80808b346446f4a9cda9e7cef4
Makes tests inherit from ActionView::TestCase.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8277 e93f8b46-1217-0410-a6f0-8f06a7374b81

--HG--
extra : source : d1015554c14b13eebe07c0b10beeafef97a43d39
Additional tests for IssuesHelper#show_detail.
--HG--
extra : source : f8f4b70fae0ee0b3785024af5c91089ebd9fa2dd
remove object_daddy dependency
--HG--
rename : test/object_daddy_helpers.rb => test/object_helpers.rb
extra : source : f41b644cb6dcab95432f8bcd579cac1e05c1753c
pin minitest version 4
<pre>
$ rake db:migrate RAILS_ENV=test

*** Mocha deprecation warning: Change `require 'mocha'` to `require 'mocha/setup'`.

rake aborted!
MiniTest v5.0.6 is out of date.
`gem install minitest` and add `gem 'minitest' to you test helper.
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/turn-0.9.6/lib/turn/minitest.rb:23:in `<top (required)>'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `block in require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:236:in `load_dependency'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/gems/turn-0.9.6/lib/turn.rb:13:in `<top (required)>'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:72:in `require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:72:in `block (2 levels) in require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:70:in `each'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:70:in `block in require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:59:in `each'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler/runtime.rb:59:in `require'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448@global/gems/bundler-1.3.5/lib/bundler.rb:132:in `require'
/REDMINE-1/git-workdir/redmine/config/application.rb:7:in `<top (required)>'
/REDMINE-1/git-workdir/redmine/Rakefile:4:in `require'
/REDMINE-1/git-workdir/redmine/Rakefile:4:in `<top (required)>'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/bin/ruby_noexec_wrapper:14:in `eval'
/home/xxxxxx/.rvm/gems/ruby-1.9.3-p448/bin/ruby_noexec_wrapper:14:in `<main>'
(See full trace by running task with --trace)
</pre>

--HG--
extra : source : 482ca5fe94358b6f672bd6d9a770469217d4c15c
Toshi MARUYAMA
rdoctask
--HG--
extra : source : 5b5f2f9b509d722293678bf7ddff53214fc1df35
Toshi MARUYAMA
application.rb
--HG--
extra : source : 1889c3ff0ef7d89be245a8f8051926fadefcec9c
Toshi MARUYAMA
application.rb
--HG--
extra : source : 050d2d3b8e5a1ce0021293ed3295de2521b46c7e
Toshi MARUYAMA
db/migrate/20100714111653_build_initial_journals_for_acts_as_journali…
…zed.rb

--HG--
extra : source : 34e2203627270feb7187712230838ccead037904
Toshi MARUYAMA
dispatcher
--HG--
extra : source : c649793a9bbb72a579dde6892c0c3719d8f00153
use ActiveSupport::TestCase instead of HelperTestCase
ActionView::Helpers::ActiveRecordHelper at test/helper_testcase.rb
does not exist on Rails 3.0.

--HG--
extra : source : a8c76e7910f22e8261f23f0aa73b0a38752d6ef8
use ActionView::TestCase instead of HelperTestCase
ActionView::Helpers::ActiveRecordHelper at test/helper_testcase.rb
does not exist on Rails 3.0.

--HG--
extra : source : 974ee7ecaf8da00e19ca1aa8661938771e48ebb3
Get rid of HelperTestcase.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8278 e93f8b46-1217-0410-a6f0-8f06a7374b81

--HG--
extra : source : 3eb2f1276ca18f771a38f78ad325bfba6d77fef8
Toshi MARUYAMA
Rakefile
--HG--
extra : source : aa13be89fd5d42b09f78f2df32bd3f3743433f96
Toshi MARUYAMA
10-patches.rb
--HG--
extra : source : 136b292c3d409364e20a141d3c6670516985294c
remove "generate_session_store" and "db:migrate:plugins" from ci:trav…
…is rake task

--HG--
extra : source : d8ebacc3a619236614a635c126a57537d90a887f

This was referenced Jul 20, 2013

@marutosi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2013

I send new pull request #315.

@marutosi marutosi closed this Jul 22, 2013

@marutosi marutosi deleted the marutosi:rails3.1-v2 branch Jul 22, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.