Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of the card, mana cost and flavor text misaligned #21

Closed
ImperatorJulius opened this issue Nov 1, 2020 · 4 comments
Closed

Name of the card, mana cost and flavor text misaligned #21

ImperatorJulius opened this issue Nov 1, 2020 · 4 comments

Comments

@ImperatorJulius
Copy link

Hello,
The script seems to works just fine, but the name of the card and mana cost are misaligned off the card.
The flavor text is weirdly cutted, see the pictures to see what i mean.
Any ideas on how to fix it?

https://imgur.com/a/dydWgRW

Windows 10
Photoshop CS6 13.0.1 x32

PS: Also, any ideas on how to change the language of the cards since scryfall also provides infos in other languages.

@ImperatorJulius
Copy link
Author

By changing line 751 in proxy.jsx Justification.RIGHT to Justification.LEFT seems to work for mana cost.

https://imgur.com/a/yUD9tjs

@ImperatorJulius
Copy link
Author

ImperatorJulius commented Nov 1, 2020

I placed an error just before image saving to see where is the problem.
Card Name and Card Type are justified to the RIGHT instead of LEFT. By manually fixing it, it works fine. At one point the justification must be swapped, but i don't know where.
For the flavor text, since it is generated as an image with the rule text, i can't manually fix it.

@ImperatorJulius
Copy link
Author

ImperatorJulius commented Nov 2, 2020

I used the solution of #14 by @hunz-dev consisting in forcing the justification for the name and cardtype.
It looks like this:
For the card name, from ligne 18 to line20
https://gist.github.com/ImperatorJulius/795eb3cd8c49b960fb75ee4ba00e3bff#file-gistfile1-txt-L18

For the card type, from ligne 40 to line 42
https://gist.github.com/ImperatorJulius/795eb3cd8c49b960fb75ee4ba00e3bff#file-gistfile1-txt-L40

For the flavor text, i just removed it since i have no solution.

@ndepaola
Copy link
Collaborator

this is fixed in the project rewrite from a few months ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants