Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

连续动态切流两次新的video中poster会设置为当前页面URL #35

Closed
huzunjie opened this issue Nov 22, 2017 · 0 comments
Closed
Assignees

Comments

@huzunjie
Copy link
Member

huzunjie commented Nov 22, 2017

第一次热切换 video 属性复制会默认<video poster ...>,这时再切流复制video属性会读到poster为空字符串,设置给新的videoElement后浏览器将空字串会解析为当前页URL

复现场景:http://chimee.org/demo/live-clarity.html

系统环境: MAC Chrome 62.0.3202.94

相关代码:

if (key !== 'src') this.videoConfig[key] = originVideoConfig[key];

需要增加判断,避免默认值为空时被置为空字串-从而导致浏览器解析为当前页URL。

@toxic-johann toxic-johann self-assigned this Nov 22, 2017
toxic-johann added a commit that referenced this issue Nov 25, 2017
toxic-johann added a commit that referenced this issue Nov 25, 2017
closed [#35](#35)
toxic-johann added a commit that referenced this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants