Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for assignment to enum variable from expression of different type #49

Merged
merged 2 commits into from May 27, 2020

Conversation

dawidzim
Copy link
Contributor

@dawidzim dawidzim commented Apr 2, 2020

Hey!
In this pull request I fixed assignment to enum from different type. Enum should be assignment only by enum type. LRM1800-2017 6.19.4: A cast shall be required for an expression that is assigned to an enum variable where the type of the expression is not equivalent to the enumeration type of the variable.

@jrahmeh
Copy link
Collaborator

jrahmeh commented May 27, 2020

Accepted. Merged. Thank you.

@jrahmeh jrahmeh merged commit 27507b7 into chipsalliance:master May 27, 2020
@jrahmeh
Copy link
Collaborator

jrahmeh commented May 27, 2020

Unfortunately this broke other tools. I will need to revert it. We will do another fix.

@dawidzim
Copy link
Contributor Author

dawidzim commented Jun 4, 2020

Should I reopen this pull request or create issue about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants