Merged PR 134981: Update kv scan sequence

Update lower level scan mode sequence to make debugUnlock input to KV a pulse instead of a level Add some helpful prints to predictor Related work items: #591177
chipsalliance · Dec 1, 2023 · c5884b8 · c5884b8
1 parent 340a3cd
commit c5884b8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/...uvmf_template_output/verification_ip/environment_packages/kv_env_pkg/src/kv_predictor.svh b/...uvmf_template_output/verification_ip/environment_packages/kv_env_pkg/src/kv_predictor.svh
@@ -332,6 +332,7 @@ class kv_predictor #(
       p_kv_rm.val_reg.debug_mode_unlocked.set(1'b1);
       p_kv_rm.val_reg.cptra_in_debug_scan_mode.set(1'b1);
 
+      `uvm_info("PRED", "Clear_secrets reg is set in debug/scan mode. Flushing KV", UVM_MEDIUM)
       if (clear_secrets_data[p_kv_rm.kv_reg_rm.CLEAR_SECRETS.sel_debug_value.get_lsb_pos()] == 'h1) begin
         for(entry = 0; entry < KV_NUM_KEYS; entry++) begin
           //Debug mode should flush all regs inspite of locks
@@ -654,6 +655,7 @@ class kv_predictor #(
           //Only allow clear operation if in debug mode
           //if (data_active[1:0] == 'h1) begin
           if (data_active [p_kv_rm.kv_reg_rm.CLEAR_SECRETS.wr_debug_values.get_lsb_pos()] && !data_active[p_kv_rm.kv_reg_rm.CLEAR_SECRETS.sel_debug_value.get_lsb_pos()]) begin
+            `uvm_info("PRED", "Clear_secrets reg is set in debug/scan mode. Flushing KV with DEBUG0 values", UVM_MEDIUM)
             for(entry = 0; entry < KV_NUM_KEYS; entry++) begin
               //Read locks before clearing - do not clear if locked
               kv_reg = p_kv_rm.get_reg_by_name($sformatf("KEY_CTRL[%0d]",entry));
@@ -668,6 +670,7 @@ class kv_predictor #(
           end
           //else if(data_active[1:0] == 'h3) begin
           else if (data_active [p_kv_rm.kv_reg_rm.CLEAR_SECRETS.wr_debug_values.get_lsb_pos()] && data_active[p_kv_rm.kv_reg_rm.CLEAR_SECRETS.sel_debug_value.get_lsb_pos()]) begin
+            `uvm_info("PRED", "Clear_secrets reg is set in debug/scan mode. Flushing KV with DEBUG1 values", UVM_MEDIUM)
             for(entry = 0; entry < KV_NUM_KEYS; entry++) begin
               //Read locks before clearing
               kv_reg = p_kv_rm.get_reg_by_name($sformatf("KEY_CTRL[%0d]",entry));

diff --git a/...late_output/verification_ip/interface_packages/kv_rst_pkg/src/kv_rst_scan_on_sequence.svh b/...late_output/verification_ip/interface_packages/kv_rst_pkg/src/kv_rst_scan_on_sequence.svh
@@ -46,12 +46,27 @@ class kv_rst_scan_on_sequence extends kv_rst_sequence_base;
 
   task body();
 
-    // Assert debug mode
-    req=kv_rst_transaction::type_id::create("pwr_req");
+    // Assert scan mode, debugUnlock_or_scan_mode_switch
+    req=kv_rst_transaction::type_id::create("dbg_on_req");
     start_item(req);
     // Randomize the transaction
     if(!req.randomize()) `uvm_fatal("KV_RST_SCAN_ON", "kv_rst_scan_on_sequence::body()-kv_rst_transaction randomization failed")
-    `uvm_info("KV_RST_SCAN_ON", "Enabling scan mode", UVM_MEDIUM)
+    `uvm_info("KV_RST_SCAN_ON", "Enabling scan mode, emulate pulse on debug_mode input", UVM_MEDIUM)
+    req.set_pwrgood = 1'b1;
+    req.assert_rst = 1'b0;
+    req.assert_core_rst = 1'b0;
+    req.debug_mode = 1'b1;
+    req.scan_mode = 1'b1;
+
+    finish_item(req);
+    `uvm_info("KV_RST_SCAN_ON", {"Response:",req.convert2string()},UVM_MEDIUM)
+
+    // Assert scan mode, deassert debugUnlock_or_scan_mode_switch
+    req=kv_rst_transaction::type_id::create("dbg_off_req");
+    start_item(req);
+    // Randomize the transaction
+    if(!req.randomize()) `uvm_fatal("KV_RST_SCAN_ON", "kv_rst_scan_on_sequence::body()-kv_rst_transaction randomization failed")
+    `uvm_info("KV_RST_SCAN_ON", "Reset debug_mode input", UVM_MEDIUM)
     req.set_pwrgood = 1'b1;
     req.assert_rst = 1'b0;
     req.assert_core_rst = 1'b0;