Update CaliptraIntegrationSpecification.md #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating integration parameter table to include the file where the define/parameter is present as well as updating the names to match RTL.
Nitsirks
requested review from
andreslagarcavilla,
calebofearth and
steph-morton
steph-morton
previously approved these changes
Nov 3, 2023
|
@Nitsirks Is the expectation that if an Integrator needs to alter these values they edit the package or header files? |
|
At this point, yes that's the expectation. Future release will move these parameters to the top level of the wrapper. |
|
OK then, within |
mcockrell-google
previously approved these changes
Nov 3, 2023
calebofearth
reviewed
Nov 3, 2023
Moving "defines" to defines table
Nitsirks
dismissed stale reviews from mcockrell-google and steph-morton
via
2b21b0d
calebofearth
approved these changes
Nov 3, 2023
steven-bellock
approved these changes
Nov 3, 2023
andreslagarcavilla
approved these changes
Nov 4, 2023
steven-bellock
added a commit
to steven-bellock/caliptra-rtl
that referenced
this pull request
Nov 5, 2023
Follow-up to chipsalliance#279. Signed-off-by: Steven Bellock <sbellock@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating integration parameter table to include the file where the define/parameter is present as well as updating the names to match RTL.
Closes #278