Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FMC reset flows layout. #135

Merged
merged 2 commits into from
Apr 5, 2023
Merged

FMC reset flows layout. #135

merged 2 commits into from
Apr 5, 2023

Conversation

rusty1968
Copy link
Contributor

Execute specialized FMC flows based on reset reason.

@rusty1968 rusty1968 force-pushed the antrocha/fmc-reset-flow branch 4 times, most recently from 0ee4b79 to 5699b69 Compare April 3, 2023 08:06
@rusty1968 rusty1968 self-assigned this Apr 3, 2023
@rusty1968 rusty1968 force-pushed the antrocha/fmc-reset-flow branch 5 times, most recently from 2a7817b to cf95b6d Compare April 4, 2023 20:41
@rusty1968 rusty1968 requested a review from jhand2 April 4, 2023 20:53
jhand2
jhand2 reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it about half way. I'll try to get to the rest by end-of-day.

Sorry for the delay in looking at this.

fmc/src/flow/cold_reset.rs Show resolved Hide resolved
fmc/src/flow/crypto.rs Outdated Show resolved Hide resolved
fmc/src/flow/dice.rs Show resolved Hide resolved
fmc/src/flow/dice.rs Outdated Show resolved Hide resolved
@rusty1968 rusty1968 force-pushed the antrocha/fmc-reset-flow branch 5 times, most recently from 7c9214a to 5e9362b Compare April 4, 2023 22:56
jhand2
jhand2 reviewed Apr 5, 2023
View reviewed changes
fmc/src/flow/mod.rs Show resolved Hide resolved
fmc/src/main.rs Show resolved Hide resolved
@rusty1968 rusty1968 mentioned this pull request Apr 5, 2023
Closed
@rusty1968
Copy link
Contributor Author

@jhand2 do you have write permissions to merge?

@jhand2
Copy link
Collaborator

jhand2 commented Apr 5, 2023

@jhand2 do you have write permissions to merge?

I do not :)

cc @korran

@JohnTraverAmd JohnTraverAmd merged commit f8d9c5b into main Apr 5, 2023
@rusty1968 rusty1968 deleted the antrocha/fmc-reset-flow branch April 6, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

@FerralCoder FerralCoder Awaiting requested review from FerralCoder FerralCoder is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Assignees

@rusty1968 rusty1968

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rusty1968 @jhand2 @JohnTraverAmd