Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test demonstrating a ref to an aggregate member #3369

Merged
merged 1 commit into from Jun 20, 2023
Merged

Add test demonstrating a ref to an aggregate member #3369

merged 1 commit into from Jun 20, 2023

Conversation

trilorez
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mwachs5 mwachs5 added the Internal Internal change, does not affect users, will be included in release notes label Jun 20, 2023
@mwachs5 mwachs5 added this to the 5.x milestone Jun 20, 2023
jackkoenig
jackkoenig reviewed Jun 20, 2023
View reviewed changes
src/test/scala/chiselTests/interface/InterfaceSpec.scala
x := read(refInterface.io.r)
}

val dir = new java.io.File("test_run_dir/interface/InterfaceSpec/should-support-ref-types-to-aggregates")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we better derive this directory? There are utility functions to generate test directories.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this same feedback applies throughout this file so I won't block this particular PR on it but let's please clean this aspect of the tests up.

@jackkoenig jackkoenig modified the milestones: 5.x, 6.0 Jun 20, 2023
@jackkoenig
Copy link
Contributor

Ref types do not exist in 5.x so I've changed the Milestone

@jackkoenig jackkoenig merged commit b0f9fe0 into chipsalliance:main Jun 20, 2023
15 of 16 checks passed
@trilorez trilorez deleted the aggregate-ref-example branch June 20, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig left review comments

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trilorez @jackkoenig @mwachs5