Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SourceLineNoCol #3433

Merged
merged 2 commits into from Jul 21, 2023
Merged

Remove SourceLineNoCol #3433

merged 2 commits into from Jul 21, 2023

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jul 20, 2023

It causes issues in downstream codebases and really adding it just isn't worth the pain.

Removes an API added in #3414

Will need to be included in #3430 and #3431.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

No release notes

Type of Improvement

  • API modification
  • BugFix

(Modification of an API that is not-yet-released)

Desired Merge Strategy

  • Squash

Release Notes

Tweak emission of source locators in error messages to match format in emitting FIRRTL (removed the : between filename and line number).

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

It causes issues in downstream codebases and really adding it just isn't
worth the pain.
@jackkoenig jackkoenig added the No Release Notes Exclude from release notes, consider using Internal instead label Jul 20, 2023
@jackkoenig jackkoenig mentioned this pull request Jul 20, 2023
14 tasks
@jackkoenig jackkoenig added Bugfix Fixes a bug, will be included in release notes and removed No Release Notes Exclude from release notes, consider using Internal instead labels Jul 20, 2023
@jackkoenig jackkoenig merged commit dd6e60f into main Jul 21, 2023
16 checks passed
@jackkoenig jackkoenig deleted the remove-sourcelinenocol branch July 21, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant