Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Binder] Corrent chirrtl.memoryport position #3544

Merged
merged 1 commit into from Sep 23, 2023
Merged

[Binder] Corrent chirrtl.memoryport position #3544

merged 1 commit into from Sep 23, 2023

Conversation

SpriteOvO
Copy link
Member

@SpriteOvO SpriteOvO commented Sep 22, 2023 •
edited

If the current position is under a when context, insert chirrtl.memoryport before the whenBegin, and leave chirrtl.memoryport.access inside the when branch.

If the current position is under a when context, insert chirrtl.memoryport before the root whenBegin, and leave chirrtl.memoryport.access inside the when branch.

If not, insert chirrtl.memoryport directly and followed by a chirrtl.memoryport.access.

@SpriteOvO SpriteOvO force-pushed the binder-correct-mem-port branch 2 times, most recently from 82c6d3f to bdc654a Compare September 22, 2023 08:18
@SpriteOvO SpriteOvO force-pushed the binder-correct-mem-port branch 3 times, most recently from 69e0090 to 4ae3429 Compare September 22, 2023 08:21
@sequencer sequencer added the Bugfix Fixes a bug, will be included in release notes label Sep 22, 2023
@sequencer sequencer merged commit 66d7dec into chipsalliance:main Sep 23, 2023
15 checks passed
@SpriteOvO SpriteOvO deleted the binder-correct-mem-port branch September 23, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer approved these changes

Assignees
No one assigned
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SpriteOvO @sequencer