Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Path property target type serialization. #3601

Merged
merged 4 commits into from Oct 26, 2023

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This includes two changes to how Path property target types are serialized:

  • For ModuleTargets, use the OMInstanceTarget target type, like for InstanceTargets
  • Add a new API to request "member" target types

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Bugfix Fixes a bug, will be included in release notes label Oct 24, 2023
@mikeurbach mikeurbach added this to the 6.0 milestone Oct 24, 2023
@mikeurbach mikeurbach marked this pull request as ready for review October 25, 2023 22:38
@jackkoenig
Copy link
Contributor

Meta point, should this be exposed as isMemberPath? Is there a more descriptive name we could give to the behavior? @albertchen-sifive @mikeurbach

@mikeurbach
Copy link
Contributor Author

Meta point, should this be exposed as isMemberPath? Is there a more descriptive name we could give to the behavior?

I think isMemberPath is better. Maybe for full granularity it could be something like isMemberTargetType, but I don't know how useful "target type" is in the name.

@mikeurbach mikeurbach merged commit 6abb3ac into main Oct 26, 2023
15 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/path-module-target branch October 26, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants