Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment: Don't require a Connectable base, split. #3612

Merged

Conversation

dtzSiFive
Copy link
Member

No non-internal existing functionality intended to be changed.

"Alignment" interface (internal) does change.

DataMirror methods implemented in terms of Alignment no longer require the Data to be hardware, allowing walking (bare) Chisel types and their alignments.

This will be used in a follow-on PR.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
    • This PR is meant to only refactor while supporting existing behavior. New functionality will follow.
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

DataMirror methods relating to alignment such as collectAlignedDeep) no longer require Data to be Hardware and may be used on bare Chisel types.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

No non-internal existing functionality intended to be changed.

"Alignment" interface (internal) does change.

DataMirror methods implemented in terms of Alignment no longer require the Data
to be hardware, allowing walking (bare) Chisel types and their alignments.
Copy link
Contributor

@azidar azidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@dtzSiFive dtzSiFive added API Modification Internal Internal change, does not affect users, will be included in release notes and removed API Modification labels Nov 1, 2023
@dtzSiFive dtzSiFive added this to the 6.0 milestone Nov 1, 2023
@dtzSiFive dtzSiFive merged commit 154a23b into chipsalliance:main Nov 1, 2023
17 of 20 checks passed
@dtzSiFive dtzSiFive deleted the feature/alignment-without-base branch November 1, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants