-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataMirror.isFullyAligned: add method to check data is all aligned. #3613
Merged
dtzSiFive
merged 6 commits into
chipsalliance:main
from
dtzSiFive:feature/datamirror-fully-aligned
Nov 29, 2023
Merged
DataMirror.isFullyAligned: add method to check data is all aligned. #3613
dtzSiFive
merged 6 commits into
chipsalliance:main
from
dtzSiFive:feature/datamirror-fully-aligned
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwachs5
reviewed
Oct 31, 2023
mwachs5
reviewed
Oct 31, 2023
This is not strictly same as FIRRTL passive, for example the zero-length vector test, hence not using that name specifically. But heads-up/FYI. |
dtzSiFive
force-pushed
the
feature/datamirror-fully-aligned
branch
from
November 1, 2023 21:00
ceb356b
to
51e1600
Compare
jackkoenig
reviewed
Nov 28, 2023
mwachs5
reviewed
Nov 28, 2023
mwachs5
reviewed
Nov 28, 2023
Add test (also demonstrating new ability to walk alignment of bare types).
Per reviewer suggestion, thanks @mwachs5! Co-authored-by: Megan Wachs <megan@sifive.com>
Per reviewer feedback/request, thanks!
Per reviewer request, thanks!
dtzSiFive
force-pushed
the
feature/datamirror-fully-aligned
branch
from
November 28, 2023 23:28
b405226
to
d24d4a7
Compare
dtzSiFive
added
the
Please Merge
Accepted PRs that are ready to be merged. Useful when waiting on CI.
label
Nov 28, 2023
jackkoenig
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
New feature, will be included in release notes
Please Merge
Accepted PRs that are ready to be merged. Useful when waiting on CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Add new DataMirror.isFullyAligned for checking if all members are aligned w.r.t. the given base.
Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.