Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataMirror.isFullyAligned: add method to check data is all aligned. #3613

Merged

Conversation

dtzSiFive
Copy link
Member

@dtzSiFive dtzSiFive commented Oct 31, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Add new DataMirror.isFullyAligned for checking if all members are aligned w.r.t. the given base.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@dtzSiFive
Copy link
Member Author

This is not strictly same as FIRRTL passive, for example the zero-length vector test, hence not using that name specifically. But heads-up/FYI.

@dtzSiFive dtzSiFive force-pushed the feature/datamirror-fully-aligned branch from ceb356b to 51e1600 Compare November 1, 2023 21:00
@dtzSiFive dtzSiFive added this to the 6.0 milestone Nov 1, 2023
@dtzSiFive dtzSiFive added the Feature New feature, will be included in release notes label Nov 1, 2023
@dtzSiFive dtzSiFive marked this pull request as ready for review November 1, 2023 21:01
@dtzSiFive dtzSiFive enabled auto-merge (squash) November 28, 2023 21:24
dtzSiFive and others added 6 commits November 28, 2023 17:27
Add test (also demonstrating new ability to walk alignment of bare types).
Per reviewer suggestion, thanks @mwachs5!

Co-authored-by: Megan Wachs <megan@sifive.com>
Per reviewer feedback/request, thanks!
@dtzSiFive dtzSiFive force-pushed the feature/datamirror-fully-aligned branch from b405226 to d24d4a7 Compare November 28, 2023 23:28
@dtzSiFive dtzSiFive enabled auto-merge (squash) November 28, 2023 23:55
@dtzSiFive dtzSiFive added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 28, 2023
@dtzSiFive dtzSiFive merged commit 6f9c568 into chipsalliance:main Nov 29, 2023
16 checks passed
@dtzSiFive dtzSiFive deleted the feature/datamirror-fully-aligned branch November 29, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants