Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove public vals from implicit classes that can surprisingly be
invoked yet do nothing. Many implicit classes were Value Classes which
require the argument to be a public val but the avoidance of runtime
objects compared to the rest of Chisel runtime is minimal at best.
Related issue: NA
Type of change: bug fix
Impact: API modification
This PR is not source-code compatible since someone could be accidentally invoking one of these "methods". We could instead do this via a deprecation schedule.
Development Phase: implementation
Release Notes
Removed implicitly added identity methods
.data
and.target
fromData
andDecoupledIO
, and removed.x
fromString
,Int
,Long
,BigInt
, andBoolean