Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just install Z3 from apt-get in CI #2131

Merged
merged 1 commit into from Sep 17, 2021
Merged

Just install Z3 from apt-get in CI #2131

merged 1 commit into from Sep 17, 2021

Conversation

jackkoenig
Copy link
Contributor

Z3 caching is again broken and increasing CI latency by ~50%, and worse than that, the entire added latency occurs before the useful CI checking. I'm failing to see the value of building it from source so why don't we just install such things from packages until it becomes a problem and only then build from source.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [NA] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix
  • CI performance improvement

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi
Copy link
Contributor

ekiwi commented Sep 17, 2021

Seems like you broke the espresso build. While you are at it, how about we just grab the latest espresso binary from the github repo that we control anyways? Like it is already done for the integration tests: https://github.com/chipsalliance/chisel3/blob/8dec89ebfc5988907c52e0c6f52b108a2c24a0a1/.github/workflows/test.yml#L103

Also install Espresso from pre-built binary
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@jackkoenig jackkoenig merged commit a692b6d into master Sep 17, 2021
@jackkoenig jackkoenig deleted the use-z3-from-apt-get branch September 17, 2021 19:40
@sequencer
Copy link
Member

cannot image that broke again…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants