Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Select.ios that works with Definition/Instance, fix isA behavior #2315

Merged
merged 15 commits into from
Jan 7, 2022
Merged

Add a Select.ios that works with Definition/Instance, fix isA behavior #2315

merged 15 commits into from
Jan 7, 2022

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Dec 20, 2021 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix
  • new feature/API

API Impact

Adds a Select.ios function that works with Hierarchy (Definition or Instance). This effectively exposes the .proto's .ios as part of the public API for Select.

Backend Code Generation Impact

No backend generation change as this was not available before.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Add a Select.ios function that works with Hierarchy (Definition or Instance). Fix a bug in .isA for Select APIs for Definition/Instance.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@mwachs5 mwachs5 changed the title Tweaks to Select to play with D/I Add a Select.ios that works with Definition/Instance Jan 4, 2022
@mwachs5 mwachs5 added this to the 3.5.0 milestone Jan 4, 2022
@mwachs5
Copy link
Contributor Author

mwachs5 commented Jan 4, 2022

Although this is a feature addition I would like to backport to 3.5.x

@mwachs5 mwachs5 marked this pull request as ready for review January 4, 2022 19:19
@mwachs5
Copy link
Contributor Author

mwachs5 commented Jan 4, 2022

I need to add a test

@mwachs5 mwachs5 changed the title Add a Select.ios that works with Definition/Instance Add a Select.ios that works with Definition/Instance, fix isA behavior Jan 6, 2022
jackkoenig
jackkoenig reviewed Jan 7, 2022
View reviewed changes
docs/src/cookbooks/hierarchy.md
println("```")
val y = chisel3.stage.ChiselStage.emitFirrtl(new InOutTop)
println("```")
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent example!

jackkoenig
jackkoenig approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I do have a couple of requests though.

src/test/scala/chiselTests/experimental/hierarchy/InstanceSpec.scala Outdated Show resolved Hide resolved
src/test/scala/chiselTests/experimental/hierarchy/InstanceSpec.scala Outdated Show resolved Hide resolved
src/test/scala/chiselTests/experimental/hierarchy/InstanceSpec.scala Outdated Show resolved Hide resolved
mwachs5 and others added 5 commits January 7, 2022 11:57
@mwachs5 mwachs5 enabled auto-merge (squash) January 7, 2022 22:51
@mwachs5 mwachs5 added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 7, 2022
@mwachs5 mwachs5 merged commit a1af6b7 into master Jan 7, 2022
@mwachs5 mwachs5 deleted the instance-select-tweaks branch January 7, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@jared-barocsi jared-barocsi jared-barocsi left review comments

Assignees
No one assigned
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mwachs5 @jackkoenig @jared-barocsi