Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-merge publishing (bp #2055) #2056

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

jackkoenig
Copy link
Contributor

This is a manual backport of pull request #2055 done by @jackkoenig

* Check Unidoc on all versions of Scala

  It is required for publishing and we publish every version

* Fix conflicting cross-version suffixes issue

  When running `sbt ++2.13.4 unidoc`, SBT would set the Scala version
  for the fuzzer and benchmark projects even though they aren't really
  relevant to the command. This may be a misconfiguration or a bug in
  the unidoc plugin. Whatever the case, simply making it possible for
  them to use the same version of Scala as the firrtl project (on which
  they depend) fixes the issue.

* Match versions of Scala in build.sbt and CI

* Fix unidoc issues in 2.13.4

  There is some bug in ScalaDoc not finding some links in firrtl.options
  so those links were made absolute as a workaround.

(cherry picked from commit aec9e9e)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jan 26, 2021
@jackkoenig jackkoenig merged commit de81f28 into 1.4.x Jan 26, 2021
@jackkoenig jackkoenig deleted the jackkoenig/bp/1.4.x/pr-2055 branch January 29, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant