Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir: make HashCode.toHashString public #2302

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Jul 26, 2021

This will allow chiseltest to save the hash code to disk for the purpose of caching simulation binaries.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • new feature/API

API Impact

  • HashCode produced by ir.StructuralHash now has a public str method which returns a string representation of the hash

Backend Code Generation Impact

  • none

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi requested a review from jackkoenig July 26, 2021 23:55
@ekiwi ekiwi added this to the 1.5.0 milestone Jul 26, 2021
@ekiwi ekiwi force-pushed the public-hash branch 2 times, most recently from 36428c4 to b243ddc Compare July 27, 2021 00:54
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jul 27, 2021
@ekiwi ekiwi changed the title ir: make HashCode.str public ir: make HashCode.toHashString public Jul 27, 2021
This will allow chiseltest to save
the hash code to disk for the purpose
of caching simulation binaries.
@mergify mergify bot merged commit cf5019e into chipsalliance:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants