Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smt] PropagatePresetAnnotations is now a real prereq #2325

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[smt] PropagatePresetAnnotations is now a real prereq #2325

merged 1 commit into from
Aug 10, 2021

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Aug 9, 2021

Contributor Checklist

  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • code cleanup

API Impact

  • the experimental smt/btor2 emitters now won't run the passes that model invalid + undefined memory behavior

Backend Code Generation Impact

  • SMT: no invalid modelling by default

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi force-pushed the smt-backend-propagate-as-dep branch 2 times, most recently from 4dea5d7 to e15516c Compare August 9, 2021 22:56
@ekiwi ekiwi mentioned this pull request Aug 9, 2021
Merged
11 tasks
@ekiwi ekiwi force-pushed the smt-backend-propagate-as-dep branch from e15516c to 8f79cd6 Compare August 9, 2021 23:11
@ekiwi ekiwi force-pushed the smt-backend-propagate-as-dep branch from 8f79cd6 to c7263c0 Compare August 9, 2021 23:33
@ekiwi ekiwi requested a review from seldridge August 10, 2021 15:02
seldridge
seldridge approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to FirrtlToTransitionSystem.scala look good to me!

I only glanced over the rest of the PR.

@seldridge seldridge added this to the 1.5.0 milestone Aug 10, 2021
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Aug 10, 2021
@ekiwi ekiwi merged commit 78ae5e4 into chipsalliance:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekiwi @seldridge