Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transforms.formal: ensure named statements as output #2367

Merged
merged 1 commit into from
Sep 23, 2021
Merged

transforms.formal: ensure named statements as output #2367

merged 1 commit into from
Sep 23, 2021

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Sep 23, 2021 •
edited
Loading

This fixes a problem where an assume in a submodule would loose its name and thus treadle would fail.

Contributor Checklist

  • Did you add at least one test demonstrating the PR?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • bug fix

API Impact

  • just makes sure that the output of these passes does not violate EnsureNamedStatements

Backend Code Generation Impact

  • none, but the bug was messing with firrtl downstream consumers like treadle

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi force-pushed the verification-passes-preserve-names branch from 988ad79 to f234960 Compare September 23, 2021 22:56
@ekiwi ekiwi requested a review from chick September 23, 2021 23:10
@ekiwi ekiwi added this to the 1.5.0 milestone Sep 23, 2021
chick
chick approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Sep 23, 2021
@mergify mergify bot merged commit 034445e into chipsalliance:master Sep 23, 2021
@ekiwi ekiwi mentioned this pull request Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekiwi @chick