Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AXI4 Deinterleaver: update to chisel3 to get inferred reset #2479

Merged
merged 5 commits into from May 29, 2020
Merged

AXI4 Deinterleaver: update to chisel3 to get inferred reset #2479

merged 5 commits into from May 29, 2020

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented May 18, 2020

Related issue: None

Type of change: feature request

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

Support Asynchronous Reset for AXI4 Deinterleaver

terpstra
terpstra approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@terpstra terpstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just upgrade it to chisel3, though?

@mwachs5
Copy link
Contributor Author

mwachs5 commented May 18, 2020 •
edited

yeah but I can't actually do that in the GitHub gui :)

Fiiine I am working on it.

@mwachs5
Copy link
Contributor Author

mwachs5 commented May 19, 2020 •
edited

the need for DontCares is killing me. Will push what I have in the "full chisel3 conversion" but getting a bunch of errors about the queues not being fully initialized... are all the queues instantiated not actually necessarily used?

Note: what I pushed doesn't have this problem due to the massive := DontCare hammer I applied which I would like @terpstra to take a look at

@mwachs5 mwachs5 requested a review from terpstra May 20, 2020 15:22
@mwachs5 mwachs5 force-pushed the axi4deinterleaver-inferred-reset branch from a344f71 to 109b49b Compare May 23, 2020 22:29
@mwachs5 mwachs5 changed the title AXI4 Deinterleaver: use chisel3 inferred reset AXI4 Deinterleaver: update to chisel3 to get inferred reset May 23, 2020
@mwachs5 mwachs5 requested a review from terpstra May 23, 2020 22:30
terpstra
terpstra approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@terpstra terpstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a more targeted DontCare

src/main/scala/amba/axi4/Deinterleaver.scala Outdated Show resolved Hide resolved
@mwachs5 mwachs5 merged commit dc176fd into master May 29, 2020
@mwachs5 mwachs5 deleted the axi4deinterleaver-inferred-reset branch May 29, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terpstra terpstra terpstra approved these changes

@jackkoenig jackkoenig Awaiting requested review from jackkoenig

@ernie-sifive ernie-sifive Awaiting requested review from ernie-sifive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwachs5 @terpstra @jackkoenig