HartId/ResetVector: Correct the input width calculation #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Jun 29, 2020
mwachs5
commented
Jun 29, 2020
jackkoenig
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Follow up to #2531 which introduced this bug (https://github.com/chipsalliance/rocket-chip/blame/master/src/main/scala/tile/Core.scala#L134)
Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes
Fix a bug in the computation of HartID and ResetVector width going into the Tile due to improper use of Chisel compatibility mode functions.