Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update millbuild config for foreign module support #3587

Conversation

lordspacehog
Copy link

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes
Updates the millbuild config to allow easier use of rocket-chip in other mill based projects.

Updates millbuild config to allow easier/cleaner use of rocket-chip as a
mill foreign module dependency.
@lordspacehog
Copy link
Author

lordspacehog commented Mar 12, 2024

Requires us to merge chipsalliance/diplomacy#15 first

@sequencer
Copy link
Member

I'm not so sure if this good. in my original design intention of the build system: common.sc should be a minimal build script to declare the dependency and possible configurations. While build.sc is a release flow for THIS project.

So I'm not so sure about importing everything from build is a good story to say?

@lordspacehog
Copy link
Author

Closing this for now. working on some build system experiments that might help make our build process simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants