Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial travis config #39

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Add initial travis config #39

merged 2 commits into from
Aug 28, 2019

Conversation

tgorochowik
Copy link
Member

@tgorochowik tgorochowik commented Aug 27, 2019 •
edited

Initial travis configuration.

@tgorochowik
conf: Add python requirements file
be1344c 
Signed-off-by: Tomasz Gorochowik <tgorochowik@antmicro.com>
@dep dep bot added the dependent label Aug 27, 2019
@dep dep bot removed the dependent label Aug 27, 2019
@tgorochowik
Add initial travis config
dafa684 
Signed-off-by: Tomasz Gorochowik <tgorochowik@antmicro.com>
@mithro
Copy link
Collaborator

mithro commented Aug 27, 2019

Looks like travis is running successfully!

@tgorochowik tgorochowik changed the title [WIP] Add initial travis config Add initial travis config Aug 27, 2019
@tgorochowik
Copy link
Member Author

tgorochowik commented Aug 27, 2019 •
edited

Yup, I guess it is a good start.

Two things are checked are the moment:

  • PEP8 checks for python scripts in the tools directory
  • Whether the make report target builds successfully

@mithro Could you help with this by setting up github pages and adding a a secret variable with a deploy key/github token? (as per https://docs.travis-ci.com/user/deployment/pages/)

I guess the report deployment can be done separately so I removed the [WIP] label, but it seems I cannot setup the gh-pages myself.

@tgorochowik tgorochowik added the enhancement New feature or request label Aug 27, 2019
kgugala
kgugala approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piotr-binkowski
piotr-binkowski approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@piotr-binkowski piotr-binkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@piotr-binkowski piotr-binkowski merged commit 38927fd into chipsalliance:master Aug 28, 2019
@piotr-binkowski piotr-binkowski deleted the travis branch August 28, 2019 07:16
@tgorochowik tgorochowik mentioned this pull request Aug 28, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgugala kgugala kgugala approved these changes

@piotr-binkowski piotr-binkowski piotr-binkowski approved these changes

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgorochowik @mithro @kgugala @piotr-binkowski