Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error with Yosys 0.37 #2299

Closed
hzeller opened this issue Jan 25, 2024 · 0 comments · May be fixed by #2300
Closed

Compile error with Yosys 0.37 #2299

hzeller opened this issue Jan 25, 2024 · 0 comments · May be fixed by #2300

Comments

@hzeller
Copy link
Collaborator

hzeller commented Jan 25, 2024

Compiling with yosys 0.37, current synlig has a compile issue:

/build/source/frontends/systemverilog/uhdm_common_frontend.cc: In member function 'virtual void systemverilog_plugin::UhdmCommonFrontend::execute(std::istream*&, std::string, std::vector<std::__cxx11::basic_string<char> >, Yosys::RTLIL::Design*)':
/build/source/frontends/systemverilog/uhdm_common_frontend.cc:154:21: error: too few arguments to function 'void Yosys::AST::process(Yosys::RTLIL::Design*, AstNode*, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool)'
  154 |         AST::process(design, current_ast, dump_ast1, dump_ast2, no_dump_ptr, dump_vlog1, dump_vlog2, dump_rtlil, false, false, false, false, false,
      |         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  155 |                      false, false, false, false, false, dont_redefine, false, defer, default_nettype_wire);
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

After fixing here, we should consider sending an upstream patch to yosys: passing a myriad of boolean parameters to process() is somewhat fragile. Instead, passing a struct with values that already have a good default is probably much better.

hzeller added a commit to hzeller/synlig that referenced this issue Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track.

Unfortunately, there is no easy way to #ifdef on a yosys version
that I know of (there do not seem to be macros exposed), so this will
not compile with old versions anymore.

Fixes chipsalliance#2299
hzeller added a commit to hzeller/nixpkgs that referenced this issue Jan 26, 2024
Discussed in
NixOS#281384

This is filed as upstream issue
chipsalliance/synlig#2299

... and addressed in this pull request
chipsalliance/synlig#2300

Patched into this nix package.
tgorochowik pushed a commit that referenced this issue Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track.

Unfortunately, there is no easy way to #ifdef on a yosys version
that I know of (there do not seem to be macros exposed), so this will
not compile with old versions anymore.

Fixes #2299
tgorochowik pushed a commit that referenced this issue Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track.

Unfortunately, there is no easy way to #ifdef on a yosys version
that I know of (there do not seem to be macros exposed), so this will
not compile with old versions anymore.

Fixes #2299
hzeller added a commit to hzeller/synlig that referenced this issue Jan 27, 2024
Yosys added another parameter to AST::process(), which we have to track.

Unfortunately, there is no easy way to #ifdef on a yosys version
that I know of (there do not seem to be macros exposed), so this will
not compile with old versions anymore.

Fixes chipsalliance#2299
hzeller added a commit to hzeller/nixpkgs that referenced this issue Jan 27, 2024
Discussed in
NixOS#281384

This is filed as upstream issue
chipsalliance/synlig#2299

... and addressed in this pull request
chipsalliance/synlig#2300

Patched into this nix package.

Co-authored-by: Luflosi <luflosi@luflosi.de>
hzeller added a commit to hzeller/nixpkgs that referenced this issue Jan 27, 2024
Discussed in
NixOS#281384

This is filed as upstream issue
chipsalliance/synlig#2299

... and addressed in this pull request
chipsalliance/synlig#2300

Patched into this nix package.

Co-authored-by: Luflosi <luflosi@luflosi.de>
@hzeller hzeller closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant