-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error with Yosys 0.37 #2299
Comments
hzeller
added a commit
to hzeller/synlig
that referenced
this issue
Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track. Unfortunately, there is no easy way to #ifdef on a yosys version that I know of (there do not seem to be macros exposed), so this will not compile with old versions anymore. Fixes chipsalliance#2299
hzeller
added a commit
to hzeller/nixpkgs
that referenced
this issue
Jan 26, 2024
Discussed in NixOS#281384 This is filed as upstream issue chipsalliance/synlig#2299 ... and addressed in this pull request chipsalliance/synlig#2300 Patched into this nix package.
13 tasks
tgorochowik
pushed a commit
that referenced
this issue
Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track. Unfortunately, there is no easy way to #ifdef on a yosys version that I know of (there do not seem to be macros exposed), so this will not compile with old versions anymore. Fixes #2299
tgorochowik
pushed a commit
that referenced
this issue
Jan 26, 2024
Yosys added another parameter to AST::process(), which we have to track. Unfortunately, there is no easy way to #ifdef on a yosys version that I know of (there do not seem to be macros exposed), so this will not compile with old versions anymore. Fixes #2299
hzeller
added a commit
to hzeller/synlig
that referenced
this issue
Jan 27, 2024
Yosys added another parameter to AST::process(), which we have to track. Unfortunately, there is no easy way to #ifdef on a yosys version that I know of (there do not seem to be macros exposed), so this will not compile with old versions anymore. Fixes chipsalliance#2299
hzeller
added a commit
to hzeller/nixpkgs
that referenced
this issue
Jan 27, 2024
Discussed in NixOS#281384 This is filed as upstream issue chipsalliance/synlig#2299 ... and addressed in this pull request chipsalliance/synlig#2300 Patched into this nix package. Co-authored-by: Luflosi <luflosi@luflosi.de>
hzeller
added a commit
to hzeller/nixpkgs
that referenced
this issue
Jan 27, 2024
Discussed in NixOS#281384 This is filed as upstream issue chipsalliance/synlig#2299 ... and addressed in this pull request chipsalliance/synlig#2300 Patched into this nix package. Co-authored-by: Luflosi <luflosi@luflosi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiling with yosys 0.37, current synlig has a compile issue:
After fixing here, we should consider sending an upstream patch to yosys: passing a myriad of boolean parameters to process() is somewhat fragile. Instead, passing a struct with values that already have a good default is probably much better.
The text was updated successfully, but these errors were encountered: