Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modport declarations should start on own line #17

Closed
fangism opened this issue Nov 23, 2019 · 2 comments
Closed

modport declarations should start on own line #17

fangism opened this issue Nov 23, 2019 · 2 comments
Assignees
Labels
formatter Verilog code formatter issues good first issue Good for newcomers

Comments

@fangism
Copy link
Collaborator

fangism commented Nov 23, 2019

Formatter input:

interface foo_if;
modport tb (output a, b, input c, d);
modport dut (output a, b, input c, d);
endinterface

currently produces:

interface foo_if;
  modport tb(output a, b, input c, d); modport dut(output a, b, input c, d);
endinterface
@fangism fangism added good first issue Good for newcomers formatter Verilog code formatter issues labels Nov 23, 2019
@fangism fangism self-assigned this Nov 23, 2019
@fangism
Copy link
Collaborator Author

fangism commented Nov 23, 2019

b/144618226

@fangism
Copy link
Collaborator Author

fangism commented Nov 23, 2019

Debugging verilog_format --show_token_partition_tree reveals:

Full token partition tree:
{ ([<auto>]) @{}
  { ([<auto>]) @{0}
    { ([interface foo_if ;]) }
  }
  { (  [<auto>]) @{1}
    { (  [modport tb ( output a , b , input c , d ) ; modport dut ( output a , b , input c , d ) ;]) }
  }
  { ([endinterface]) }
}

Clearly just needs a partition cut point.

@fangism fangism added this to token partitioning in SV formatter Nov 23, 2019
@hzeller hzeller closed this as completed in 3fe7b13 Dec 2, 2019
nikhiljha pushed a commit to nikhiljha/verible that referenced this issue Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Verilog code formatter issues good first issue Good for newcomers
Projects
SV formatter
token partitioning
Development

No branches or pull requests

1 participant