[LSP] Initial support for textDocument/hover request #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
reviewed
May 17, 2023
| @@ -593,6 +593,13 @@ std::string ReferencesRequest(absl::string_view file, int id, int line, | |||
| line, character); | |||
| } | |||
|
|
|||
| // Creates a textDocument/hover request | |||
| std::string HoverRequest(absl::string_view file, int id, int line, | |||
There was a problem hiding this comment.
is the id actually a relevant value we need to pass for the tests ? If not maybe we just replace it with some static constexpr int kDummyId = 1; to not distract from the other values.
There was a problem hiding this comment.
It should be unique per request - we can go with the static value that is incremented per request
There was a problem hiding this comment.
Yep, but is any place even checking if it is unique per request ?
glatosinski
force-pushed
the
lsp-hover-support
branch
2 times, most recently
from
3f53a4b
to
fbeeed8
Compare
…ol_table header Method SymbolMetaTypeAsString is now provided by header to allow printing symbol meta types, e.g. for hover purposes Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…ding definitions and tokens To be able to use FindDefinitionLocation in other use cases than goto-definition, the parameters are now of type TextDocumentPositionParams. Also, GetTokenAtTextDocumentPosition now returns optional TokenInfo instead of absl::string_view, to provide more useful information regarding the symbol. Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…g SymbolTableNode with definition Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…content builder Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…s to Language Server Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
… for hovering over symbol Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…publicly available Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
…er on "end" Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
glatosinski
force-pushed
the
lsp-hover-support
branch
from
fbeeed8
to
18c4071
Compare
…e hover is applied, added using dedicated class Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
glatosinski
force-pushed
the
lsp-hover-support
branch
from
18c4071
to
79ce3d0
Compare
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Jan 30, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished.
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Jan 30, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished.
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Jan 31, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished.
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Feb 2, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished. The implementation requires a global symbol table, which is potentially a bit heavy. We might need to introduce the concept of a per-file symbol table for faster local lookups.
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Feb 23, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished. The implementation requires a global symbol table, which is potentially a bit heavy. We might need to introduce the concept of a per-file symbol table for faster local lookups.
hzeller
pushed a commit
to hzeller/verible
that referenced
this pull request
Feb 23, 2024
Rebased from PR chipsalliance#1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished. The implementation requires a global symbol table, which is potentially a bit heavy. We might need to introduce the concept of a per-file symbol table for faster local lookups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1187
This PR adds initial support for
textDocument/hoverrequest.It adds a HoverBuilder that constructs hover messages for the current position.
Tasks:
endendmodule,endfunctionof block (currently WIP)textDocument/hovermethod (currently WIP)