Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Initial support for textDocument/hover request #1922

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

[LSP] Initial support for textDocument/hover request #1922

wants to merge 13 commits into from

Commits on May 18, 2023

  1. verilog: analysis: symbol_table: Added SymbolMetaTypeAsString to symb… 

    …ol_table header

Method SymbolMetaTypeAsString is now provided by header to allow
printing symbol meta types, e.g. for hover purposes

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b5c7d02 View commit details
    Browse the repository at this point in the history

  2. verilog: tools: ls: symbol-table-handler: Generalized methods for fin… 

    …ding definitions and tokens

To be able to use FindDefinitionLocation in other use cases than goto-definition,
the parameters are now of type TextDocumentPositionParams.
Also, GetTokenAtTextDocumentPosition now returns optional TokenInfo instead
of absl::string_view, to provide more useful information regarding the symbol.

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    282c9b7 View commit details
    Browse the repository at this point in the history

  3. verilog: tools: ls: symbol-table-handler: Extracted method for findin… 

    …g SymbolTableNode with definition

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f02b3e4 View commit details
    Browse the repository at this point in the history

  4. verilog: tools: ls: hover: Added initial implementation of the Hover … 

    …content builder

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    264f611 View commit details
    Browse the repository at this point in the history

  5. verilog: tools: ls: verilog-language-server: Connected hover function… 

    …s to Language Server

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ae156cc View commit details
    Browse the repository at this point in the history

  6. verilog: tools: ls: verilog-language-server: test: Added initial test… 

    … for hovering over symbol

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ceb0450 View commit details
    Browse the repository at this point in the history

  7. verilog: tools: ls: BUILD: Updated dependencies for hover 

    Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    dd1b586 View commit details
    Browse the repository at this point in the history

  8. verilog: tools: ls: symbol-table-handler: Made IsStringViewContained … 

    …publicly available

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    13cb900 View commit details
    Browse the repository at this point in the history

  9. verilog: tools: ls: hover: Added providing block name when available 

    Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2204a63 View commit details
    Browse the repository at this point in the history

  10. verilog: tools: ls: verilog-language-server: test: Added test for hov… 

    …er on "end"

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1ebd71b View commit details
    Browse the repository at this point in the history

  11. verilog: tools: ls: hover: Refactored classes, added basic docstrings 

    Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0265a8b View commit details
    Browse the repository at this point in the history

  12. verilog: tools: ls: verilog-language-server: test: Marked places wher… 

    …e hover is applied, added using dedicated class

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    09ab5f1 View commit details
    Browse the repository at this point in the history

  13. verilog: tools: ls: hover: Changed IsStringViewContained to IsSubRange 

    Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
    @glatosinski
    glatosinski committed May 18, 2023
    Configuration menu
    Copy the full SHA
    79ce3d0 View commit details
    Browse the repository at this point in the history