Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clang-format on all files that are not currently open in PRs. #1963

Merged

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jul 13, 2023

This only touches files that are not currently open in any pending pull requests (except #1912, which needs to be manually rebased anyway). That way merging these will be easier.

This unifies the pointer/reference alignment between all files.

@hzeller hzeller requested a review from fangism July 13, 2023 22:09
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 98.90% and no project coverage change.

Comparison is base (cf9afe7) 92.85% compared to head (5837ec9) 92.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1963   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         355      355           
  Lines       26272    26272           
=======================================
  Hits        24395    24395           
  Misses       1877     1877           
Impacted Files Coverage Δ
common/analysis/line_linter.h 100.00% <ø> (ø)
common/analysis/syntax_tree_linter.h 100.00% <ø> (ø)
common/analysis/syntax_tree_search_test_utils.h 100.00% <ø> (ø)
common/analysis/text_structure_lint_rule.h 100.00% <ø> (ø)
common/analysis/text_structure_linter.h 100.00% <ø> (ø)
common/analysis/token_stream_lint_rule.h 100.00% <ø> (ø)
common/analysis/token_stream_linter.h 100.00% <ø> (ø)
...ommon/formatting/token_partition_tree_test_utils.h 100.00% <ø> (ø)
common/formatting/unwrapped_line_test_utils.h 100.00% <ø> (ø)
common/formatting/verification.cc 100.00% <ø> (ø)
... and 166 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This only touches files that are not currently open in any pending
pull requests (except #1912, which needs to be manually rebased
anyway). That way merging these will be easier.

This unifies the pointer/reference alignment between all files.
@hzeller hzeller force-pushed the 20230713-run-clang-format-non-open2 branch from 5837ec9 to d9ef6a0 Compare July 13, 2023 22:33
Copy link
Collaborator

@fangism fangism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, alright.

@hzeller hzeller merged commit 0fc3a5e into chipsalliance:master Jul 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants