Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for setuptools >=62.0.0 #1943

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add check for setuptools >=62.0.0 #1943

merged 1 commit into from
Sep 29, 2023

Conversation

npmitche
Copy link
Member

No description provided.

@npmitche
Add check for setuptools >=62.0.0
2227c1c 
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com>
@npmitche npmitche requested a review from a team as a code owner September 22, 2023 15:56
jun2zhou
jun2zhou previously requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@jun2zhou jun2zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the linux_requirements.txt & windows_requirements.txt files it is:
setuptools >= 62.4.0

@npmitche npmitche dismissed jun2zhou’s stale review September 28, 2023 18:31

Checking based off of manual direction.

@npmitche npmitche merged commit 5eaefb6 into chipsec:main Sep 29, 2023
38 checks passed
@npmitche npmitche deleted the npmitche/addsetuptoolsvercheck branch September 29, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sae86 Sae86 Sae86 approved these changes

@frinzell frinzell frinzell approved these changes

@jun2zhou jun2zhou jun2zhou approved these changes

@dscott90 dscott90 Awaiting requested review from dscott90

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@npmitche @Sae86 @frinzell @jun2zhou