Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typehints and fstrings to common modules #1982

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add typehints and fstrings to common modules #1982

merged 1 commit into from
Dec 1, 2023

Conversation

dscott90
Copy link
Contributor

@dscott90 dscott90 commented Nov 9, 2023

No description provided.

@dscott90 dscott90 requested a review from a team as a code owner November 9, 2023 21:28
npmitche
npmitche requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@npmitche npmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run function's args seems like it needs to remove the * and add List[str] instead of str. Needs some more testing.

@dscott90 dscott90 force-pushed the dscott/common_typehints_fstrings branch from f8198ad to 1edcb5d Compare November 14, 2023 19:36
@dscott90 dscott90 force-pushed the dscott/common_typehints_fstrings branch from 248ab25 to d474a5b Compare November 30, 2023 22:51
@dscott90 dscott90 merged commit 9667780 into chipsec:main Dec 1, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmitche npmitche npmitche approved these changes

@jun2zhou jun2zhou jun2zhou approved these changes

@Sae86 Sae86 Awaiting requested review from Sae86

@frinzell frinzell Awaiting requested review from frinzell

Assignees
No one assigned
Labels
enhancement next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dscott90 @npmitche @jun2zhou