Mob/chipsec refactor2 #2091
Merged
Mob/chipsec refactor2 #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -34,7 +34,7 @@ | |||
| from chipsec.file import * | |||
| from chipsec.module_common import * | |||
| from chipsec.hal.vmm import VMM | |||
| from chipsec.defines import * | |||
| from chipsec.library.defines import * | |||
Check notice
Code scanning / CodeQL
'import *' may pollute namespace Note
dscott90
approved these changes
Mar 19, 2024
npmitche
commented
Mar 19, 2024
Signed-off-by: Sae86 <sara.batllori@intel.com>
npmitche
force-pushed
the
mob/chipsec_refactor2
branch
from
e4763e7
to
c8aec7a
Compare
npmitche
force-pushed
the
mob/chipsec_refactor2
branch
2 times, most recently
from
5d949da
to
a5a306a
Compare
npmitche
force-pushed
the
mob/chipsec_refactor2
branch
from
a5a306a
to
a7df678
Compare
Sae86
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the chipset.py file to help readability/maintainability.