Address issue #249 #506
Merged
Address issue #249 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjorge
requested changes
Jan 7, 2019
BrentHoltsclaw
force-pushed
the
issue_249
branch
from
522fbb7
to
df8550a
Compare
ErikBjorge
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
@BrentHoltsclaw you can rebase the change and get CI to pass if you want
changed drivers/linux/include/chipsec.h to start from 'C' added logic to compute ioctl base based upon changes to chipsec.h above
BrentHoltsclaw
force-pushed
the
issue_249
branch
from
9770b16
to
3999930
Compare
mjauregu
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed drivers/linux/include/chipsec.h to start from 'C'
added logic to compute ioctl base based upon changes to chipsec.h above