Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfm #44

Closed
aackerman opened this issue Apr 13, 2012 · 9 comments
Closed

gfm #44

aackerman opened this issue Apr 13, 2012 · 9 comments

Comments

@aackerman
Copy link

Part of the Github Flavored Markdown is to support output of links that will link to users, commit sha's, repo, and issues. This is my understanding, when reading through showdown.js which is included in 'github-flavored-markdown' available on NPM. Do you have any plan for the future to add these features to the parser?

@chjj
Copy link
Member

chjj commented Apr 13, 2012

I don't like this aspect because it's specific to one website. Don't get me wrong, I love github, but it assumes that the user of marked uses github as well.

@johnmdonahue
Copy link

@chjj FWIW. I agree with your opinion here on automatic link insertion for GitHub specific links. If this were implemented we would probably need to somehow work around it for EpicEditor since it is not designed to be used specifically with GitHub.

RE: OscarGodson/EpicEditor#105

@scottgonzalez
Copy link
Contributor

GFM also runs in a specific context. While the @user syntax always runs, things like #issue and SHA1234 syntax requires passing a repo as the context. You probably don't want to add anything to marked for this.

related: #107

@carlos8f
Copy link

carlos8f commented Aug 6, 2013

+1

@carlos8f
Copy link

carlos8f commented Aug 6, 2013

For anyone interested I wrote a small module to accomplish this: https://npmjs.org/package/gfm-linkify

@jklontz
Copy link

jklontz commented Dec 14, 2013

IMO, it would be great to see this as an option that could be enabled.

@sylvia43
Copy link

Bump. Should this be closed? Or implemented? Or both?

@sylvia43
Copy link

Can we close this? We don't want this in the core framework, and there's a package for this already. Let's try to clean up issues.

@RangerMauve
Copy link

Autolinking would be useful. Especially since there being an option for gfm in the options kind of made me expect all of GFM to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants