Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening url encoded file paths #31

Open
fryedbiscuit opened this issue Jan 23, 2021 · 7 comments
Open

Opening url encoded file paths #31

fryedbiscuit opened this issue Jan 23, 2021 · 7 comments

Comments

@fryedbiscuit
Copy link

fryedbiscuit commented Jan 23, 2021

So...
Handlr seems to pass uri file paths directly to the program (differently from xdg-open) which some programs are not ready to handle.
That make the file not to be found.

example:
file://home/user/file.png
isn't parsed to
/home/user/file.png

@chmln
Copy link
Owner

chmln commented Jan 27, 2021

@bloody-scythe thanks for reporting this, will look into it

@hukacode
Copy link

Hi @chmln

I got a similar error look like the one in this link. (https://bbs.archlinux.org/viewtopic.php?id=207758)
I think it is the same issue as @bloody-scythe's issue then I mention it instead of creating a new issue.

Thank you so much for your attention, time and efforts.

@chmln
Copy link
Owner

chmln commented Apr 23, 2021

@bloody-scythe @hukacode should be fixed in the latest release :)
Please reopen this if it still doesn't work.

@chmln chmln closed this as completed Apr 23, 2021
@hukacode
Copy link

Hi @chmln

I still get this issue with version 0.6.1
I open pdf file from Calibre (screenshots in below).
I can open with another extension (epub) so I don't know if it is handlr issue or pdf issue.

Best regards,
Huka

image
image

@chmln
Copy link
Owner

chmln commented Apr 25, 2021

@hukacode It was definitely a handlr issue. I just published a fix so it should work in v0.6.3 now

@hukacode
Copy link

Hi @chmln

This is an error when I open with v0.6.3
image

In previous version, I can open "location" with file manager, but now I get this error
image

This is the file path
image

@chmln
Copy link
Owner

chmln commented Apr 25, 2021

Ahhhh I see what's happening. The path gets urlencoded. When I was testing the fix locally I didn't think to check a file with spaces. Now I just have olto urldecode the path before passing it to the program.

Thanks @hukacode !

@chmln chmln reopened this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants