sd creates corrupt files ("failed to write whole buffer")

[sharkdp]

If the replacement string has a different length than the search pattern, sd either fails with an error "failed to write whole buffer" (when the replacement string is longer) or even leaves behind corrupt files (when the replacement string is shorter).

How to reproduce:

▶ echo "foo" > dummy

▶ sd "foo" "fo" dummy

▶ hexdump -C dummy
00000000  66 6f 0a 00                                       |fo..|
00000004

Notice the additional zero byte (00) at then end.

[sharkdp]

I just now saw that this has already been reported in #37. However, the effect on Linux seems to be a bit different.

[ghost]

Same problems on FreeBSD.

[chmln]

Thanks a lot for reporting this and your correct analysis @sharkdp. The error was caused by an improper size pre-allocated for the file-backed memory map.

I've just released v0.6.1 addressing this issue.

[sharkdp]

Thank you very much for the quick bugfix!