Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boxstarter (weblauncher) always installs latest version of Chocolatey #537

Closed
4 tasks done
mwallner opened this issue Jun 8, 2023 · 5 comments · Fixed by #540
Closed
4 tasks done

Boxstarter (weblauncher) always installs latest version of Chocolatey #537

mwallner opened this issue Jun 8, 2023 · 5 comments · Fixed by #540
Assignees
@mwallner
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
3.0.2

Comments

@mwallner
Copy link
Member

mwallner commented Jun 8, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.

What You Are Seeing?

Chocolatey 1.1 is installed (packaged with Boxstarter), then Boxstarter immediately installs the latest available Chocolatey version.

image

With version 3.0.1, - caused by GH-534, Boxstarter will try to install the latest version of Chocolatey, even if the builtin/pre-packaged version of Chocolatey is installed first.

What is Expected?

Boxstarter should stick to the bundled version of Chocolatey (as it's the one that's tested and verified to work with Boxstarter), as long as the user has not manually upgraded to a newer version of Chocolatey.

How Did You Get This To Happen?

START https://boxstarter.org/package/nr/url?https://gist.githubusercontent.com/mwallner/a339c90c45978ca19e243a52b12ea3f8/raw/693e7b246b35ca967c1554e91fe5afbcf6f52dce/min-pwsh-win-boxstarter.ps1

System Details

  • Operating System: Win11 (StefanScherer Vagrant Box)

Installed Packages

-

Output Log

see screenshot above.

Additional Context

No response
@mwallner mwallner added the Bug Issues where something has happened which was not expected or intended label Jun 8, 2023
@mwallner
Copy link
Member Author

mwallner commented Jun 8, 2023

probably just add --noop to the fix of GH-534

@mwallner
Copy link
Member Author

mwallner commented Jun 8, 2023

verified that it works as intended if a (supported) version of Chocolatey is already installed when Boxstarter Weblauncher is being used:
image

@gep13
Copy link
Member

gep13 commented Jun 9, 2023

Do you see this going out as a 3.0.2?

@mwallner
Copy link
Member Author

mwallner commented Jun 9, 2023

Yes, but this might be related/ solved together with GH-536, I'm currently investigating both issues and will keep you posted.

@mwallner mwallner added this to the 3.0.2 milestone Jun 10, 2023
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 10, 2023
@mwallner
chocolateyGH-537: do not install latest version of chocolatey
dd231c1
@mwallner mwallner mentioned this issue Jun 10, 2023
Closed
mwallner added a commit to mwallner/boxstarter that referenced this issue Jun 10, 2023
@mwallner
chocolateyGH-537: do not install latest version of chocolatey
358b335
@mwallner mwallner mentioned this issue Jun 10, 2023
Merged
@gep13 gep13 added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jun 10, 2023
@gep13 gep13 linked a pull request Jun 10, 2023 that will close this issue
(#537) Do not install latest version of Chocolatey when using the WebLauncher #540
Merged
@gep13 gep13 closed this as completed Jun 10, 2023
@chocolatey chocolatey deleted a comment from choco-bot Jun 12, 2023
gep13 added a commit that referenced this issue Jun 12, 2023
@gep13
Merge branch 'hotfix/3.0.2'
396a105 
* hotfix/3.0.2:
  (build) Fix truncation of prereleaselabel
  (build) Sign the bootstapper file
  GH-537: do not install latest version of chocolatey
  GH-536: remove empty spaces from ArgumentList
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jun 12, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 3.0.2 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit that referenced this issue Jun 12, 2023
@gep13
Merge branch 'master' into develop
382dfe4 
* master:
  (build) Fix truncation of prereleaselabel
  (build) Sign the bootstapper file
  GH-537: do not install latest version of chocolatey
  GH-536: remove empty spaces from ArgumentList
  (build) Added release comment to GRM config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwallner mwallner

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

(#537) Do not install latest version of Chocolatey when using the WebLauncher mwallner/boxstarter
3 participants
@gep13 @mwallner @choco-bot