Not using zlib for varying length variables when storing in NetCDF #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also fix the CI failing, for example in https://github.com/choderalab/openmmtools/actions/runs/4169132226/jobs/7216734460 |
ijpulidos
changed the title
5 tasks
|
The test failing in https://github.com/choderalab/openmmtools/actions/runs/4177851214/jobs/7235936562#step:8:2968 is unrelated to the changes in this PR. They are related to what we already discussed with OpenMM8 in #649 . We'll be fixing that in a separate PR. |
mikemhenry
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With newer NetCDF versions there is a problem with using
zlib=Truewhen storing variables with varying length. More info at Unidata/netcdf4-python#1175Todos
Status
Changelog message