-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in createVariable between 1.5.8 and 1.6.0 #1175
Comments
Compression does not work with variable-length types. Maybe this did not cause an error with netcdf-c 4.8.1 (which was used for the netcdf4-python 1.5.8 wheel), but it looks like it does for netcdf-c 4.9.0 (which is used by the netcdf4-python 1.6.0 wheel). The error message (which comes from the C lib) is somewhat confusing though. See https://forum.hdfgroup.org/t/compression-of-variable-lenght-datatypes/1384 |
Thank you very much for the clarification, I was not aware of that. |
… 1.5.8 and 1.6.0".
* unpin xarray, numpy, pandas, netcdf4 * Fix deprecation "TypeError: Using a DataArray object to construct a variable is ambiguous, please extract the data using the .data property." See pydata/xarray#6508. There are other errors, however. * See Unidata/netcdf4-python#1175 "Regression in createVariable between 1.5.8 and 1.6.0". * Testing on Python 3.7 only covers through xarray 0.20.2. This is an experiment. * Fix get_metadata to account for the internal restructuring of indexes in xarray 2022.06. Update tests for same. * Fixed bug where we were stripping off attrs inadvertently when writing netCDF. * TestPlainGroupby.test_on_data_array fails with Python = 3.8.13, numpy = 1.23.2, xarray = 2022.06.0. That means it has nothing to do with BrainIO. * test_on_data_array should not involve any BrainIO classes. This is to test for bugs in xarray. With xarray==2022.06.0, this test fails. * xarray 2022.06.0 has a bug which breaks BrainIO: pydata/xarray#6836. * Adapt get_metadata to the change in the index API between 2022.03.0 and 2022.06.0. Now test_get_metadata passes under 2022.03.0 and 2022.06.0. * Getting an error from tests on Travis (but not locally): RuntimeError: NetCDF: Filter error: bad id or parameters or duplicate filter. This might fix it? * Compression test failed: assert 614732 > 615186. This might fix it. * Travis doesn't offer python 3.10 yet. Make sample assembly bigger so compression has an effect. * Bump minor version. Authored-by: Jonathan Prescott-Roy <jjpr@mit.edu> and Martin Schrimpf <msch@mit.edu>
See the attached file to reproduce the behaviour, it works with 1.5.8, but does not with 1.6.0, but instead prints the following error message:
The text was updated successfully, but these errors were encountered: