Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICard.tags property #98

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Add ICard.tags property #98

merged 2 commits into from
Sep 22, 2021

Conversation

shangzhel
Copy link
Collaborator

Because nobody caught the error.

Closes #82 again.

@shangzhel shangzhel added the bug Something isn't working label Sep 21, 2021
@shangzhel shangzhel added this to the Sprint 2 milestone Sep 21, 2021
@shangzhel shangzhel self-assigned this Sep 21, 2021
@waltervan00
Copy link
Collaborator

Would we want an update function for the Tag controller -- as to have 'live feedback' for when tags are updated?
The current plan was to have commit() be called when the edit tag panel closes. Until then, the changes made to the tags would be restricted to the component trees of #84.

@shangzhel
Copy link
Collaborator Author

And that's fine, because tags don't need to globally update until the changes to a tag is confirmed.

@waltervan00 waltervan00 merged commit e0d5b8d into master Sep 22, 2021
@waltervan00 waltervan00 deleted the shangzhel/tag-controller branch September 22, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltervan00 waltervan00 waltervan00 approved these changes

Assignees

@shangzhel shangzhel

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

Implement app tag controllers
2 participants
@shangzhel @waltervan00