Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Memory leak introduced with updated data cache API #235

Closed
bruth opened this issue Oct 3, 2014 · 1 comment · Fixed by #236
Closed

Memory leak introduced with updated data cache API #235

bruth opened this issue Oct 3, 2014 · 1 comment · Fixed by #236
Labels
type:bug

Comments

@bruth
Copy link
Contributor

bruth commented Oct 3, 2014

This is most likely being caused by Serrano passing a queryset that is being evaluated during cache key creation.
@bruth bruth added the type:bug label Oct 3, 2014
@bruth
Copy link
Contributor Author

bruth commented Oct 3, 2014

This is due to aggregator instances being pickled which is causing the internal querysets to be evaluated and loaded into memory. The other realization this brought was the data cache API was not doing anything for those computed values anyway since they were cached unevaluated.. so the database hit would occur anyway on retrieval.

bruth added a commit that referenced this issue Oct 3, 2014
@bruth
Add custom pickling support for Aggregator class
bc2bf0e 
This ensures the internal queryset does not get evaluated when the
aggregator instance is pickled.

Fix #235

Signed-off-by: Byron Ruth <b@devel.io>
@bruth bruth mentioned this issue Oct 3, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom pickling support for Aggregator class chop-dbhi/avocado
1 participant
@bruth