This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Refactor formatter for model-derived typing #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| values = OrderedDict(zip(self.keys, values)) | ||
|
|
||
| # Create a copy of the preferred formats since each set values may |
There was a problem hiding this comment.
Clarify ...formats since each set values map.... That part of the sentence is confusing.
This improves formatter processing to consider the `DataConcept` and `DataField` `type` fields introduced in 878a313 and cddcd9b, respectively. In addition, the `DataField`'s simple type is included as a fallback prior to using the 'raw' format. This removes the need for `Formatter.default_formats` and reduces the number of the `preferred_formats` across the exporter classes. Fix #242 Signed-off-by: Byron Ruth <b@devel.io>
naegelyd
added a commit
that referenced
this pull request
Oct 15, 2014
Refactor formatter for model-derived typing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves formatter processing to consider the
DataConceptandDataFieldtypefields introduced in 878a313 and cddcd9b,respectively. In addition, the
DataField's simple type is included asa fallback prior to using the 'raw' format.
This removes the need for
Formatter.default_formatsand reduces thenumber of the
preferred_formatsacross the exporter classes.Fix #242
Signed-off-by: Byron Ruth b@devel.io