-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support submetrics #37
Conversation
I still need to fix the way we detect if there are wultiple values per metrics so this is still WIP |
34f1d33
to
6192d94
Compare
Fixed, and added tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dive in too deep, but the basic premise and implementation LGTM. 👍
config_test.go
Outdated
want: []*Query{ | ||
&Query{ | ||
Name: "query_ds_1", | ||
SQL: "select 1 as \"sum\", 2 as \"count\" from dual\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer literal strings (backticks) when using double quotes in a string.
`select 1 as "sum" ...`
set.go
Outdated
} | ||
} | ||
// it is a facet field and not a submetric field | ||
if submetric == false { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer if !submetric {
rather than equality to false
.
Looks good otherwise! |
Fixes chop-dbhi#36 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
6192d94
to
6734bda
Compare
@bruth I addressed your comments. |
👍 Nice work |
Fixes #36
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu