This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
(#494) Fix base class lock implimentation #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lock method has changed to take only 2 parameters but the base class was never updated resulting in a method signature error rather than the intended friendlier error indicating the data source does not support locks
ripienaar
added a commit
to ripienaar/mcollective-choria
that referenced
this pull request
May 21, 2018
Puppet does not seem to like the NotImplementedError - fails silently - this ensure failures are clearer
ripienaar
added a commit
to ripienaar/mcollective-choria
that referenced
this pull request
May 21, 2018
Puppet does not seem to like the NotImplementedError, fails silently, this ensure failures are clearer
ripienaar
added a commit
that referenced
this pull request
May 21, 2018
(#495) ensure errors raised will be noticed by Puppet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock method has changed to take only 2 parameters but the base
class was never updated resulting in a method signature error rather
than the intended friendlier error indicating the data source does
not support locks