Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap async_chat instead of inheriting? #6

Closed
tdoylend opened this issue Jun 12, 2017 · 2 comments
Closed

Wrap async_chat instead of inheriting? #6

tdoylend opened this issue Jun 12, 2017 · 2 comments

Comments

@tdoylend
Copy link
Contributor

Currently, Channel inherits from async_chat. This means it gets the really wonky async_chat.getattr method, which causes problems like this.

I propose that instead of inheriting, we make Channel (and also EndPoint, by extension) a wrapper around async_chat. That way, error messages can be more helpful and PodSixNet can move closer to PEP-8 by not having capitalized methods.

I'm willing to do this and submit a PR if @chr15m thinks this is a good idea.

@chr15m
Copy link
Owner

chr15m commented Jun 14, 2017

Excellent, sounds great, thanks @tdoylend! This could help the Python 3 port as well. Let me know when there is a PR to review.

@chr15m
Copy link
Owner

chr15m commented Sep 12, 2018

@tdoylend feel free to re-open this if you submit such a PR. Thanks!

@chr15m chr15m closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants