You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Channel inherits from async_chat. This means it gets the really wonky async_chat.getattr method, which causes problems like this.
I propose that instead of inheriting, we make Channel (and also EndPoint, by extension) a wrapper around async_chat. That way, error messages can be more helpful and PodSixNet can move closer to PEP-8 by not having capitalized methods.
I'm willing to do this and submit a PR if @chr15m thinks this is a good idea.
The text was updated successfully, but these errors were encountered:
Currently, Channel inherits from async_chat. This means it gets the really wonky async_chat.getattr method, which causes problems like this.
I propose that instead of inheriting, we make Channel (and also EndPoint, by extension) a wrapper around async_chat. That way, error messages can be more helpful and PodSixNet can move closer to PEP-8 by not having capitalized methods.
I'm willing to do this and submit a PR if @chr15m thinks this is a good idea.
The text was updated successfully, but these errors were encountered: