Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature wish: --indep-r2 #8

Closed
kforner opened this issue Jun 5, 2014 · 6 comments
Closed

Feature wish: --indep-r2 #8

kforner opened this issue Jun 5, 2014 · 6 comments

Comments

@kforner
Copy link

kforner commented Jun 5, 2014

Hi,
It would be nice to have a --indep-r2, (or --indep-pairwise dprime) that selects tag SNPs based on the real (haplotype-based) r^2.
Rationale:

  • the non-haplotype based r^2 is an approximation
  • it seems that the haplotype-based r^2 is slower to compute, but not that slow. On my tests it is roughly 3 times slower to compute
  • it would be consistent with --ld

Anyway, thanks for this great software.

@chrchang
Copy link
Owner

chrchang commented Jun 5, 2014

A fully powered version of this (capable of using SHAPEIT's results, etc.) is planned for PLINK 2.0. I'll ask around and see if there's substantial demand for a "bad phasing" --indep-pairwise in v1.9, though.

@kforner
Copy link
Author

kforner commented Jun 5, 2014

When you say "bad phasing", you mean a pairwise maximum-likelihood estimate of the phase as opposed to the shapeit algorithm that uses information from all snps I guess ?

@chrchang
Copy link
Owner

chrchang commented Jun 5, 2014

Correct. There's existing software which performs the more accurate r^2 computation (e.g. VCFtools --hap-r2), and one can write a script to select variants in an indep-pairwise-like manner using those results if the additional accuracy is important today.

@kforner
Copy link
Author

kforner commented Jun 5, 2014

I just saw that you recommend to use the google group for feedback. Do you prefer that I post the feature request there for the record ?

@chrchang
Copy link
Owner

chrchang commented Jun 5, 2014

That's a good way to gauge additional interest in this feature, yes.

@kforner
Copy link
Author

kforner commented Jun 5, 2014

@kforner kforner closed this as completed Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants