Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.livestream: Update for API changes #1277

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

intact
Copy link
Contributor

@intact intact commented Apr 9, 2016

No description provided.

@stevekmcc
Copy link

I can confirm that this fixes the problems in #1272 and #1318. Hopefully it can be integrated in the next release!

@0880 0880 mentioned this pull request Aug 2, 2016
@Junior1544
Copy link

How would I install this fix since it's not part of the main files?

I'm brand new and have little idea on how to do things... This is for a Raspberry Pi that I'm just learning about...

Thanks!

@stevekmcc
Copy link

stevekmcc commented Aug 3, 2016

It was my first manual change to a Pip package too, so I can sympathize, @Junior1544 ! Unfortunately I don't remember the details (I was having to fix it while the stream was live, so it was kind of hectic): certainly it starts by finding that file (click the Files Changed tab above the first comment above to see the relative filename). Finding the right base directory containing that relative filename wasn't particularly easy. Editing the file was OK, I think I had to sudo the editor to be able to save. And I think there was another step after that to get it compiled or make sure it was used next time, but sadly I don't remember now. I was hoping it would be integrated quickly, as in the past, but there have been no commits here since January :(

EDIT 2016-11-20: Since I wrote, two extra commits were added in September to the original changeset from April 2016. With those extra commits, this no longer works for me, and I get an error message "A SWF URL is required to create session token'. Using just the April commit works fine still. The streamlink fork includes all 3 commits, and fails with that same 'session token' error message.

To manually change the file, copy the whole file from that first commit, 1c56fb2, e.g. to ~/livestream.py. Then find the directory where your installed livestream.py is (e.g. "find / -name livestream.py -ls >find.txt", and "cat find.txt"), and replace livestream.py there with ~/livestream.py. Delete livestream.pyc in that directory too.

@intact intact changed the title plugins.livestream: Prefer standard SWF players plugins.livestream: Update for API changes Sep 2, 2016
@mariobede
Copy link

works on my machine like a charm

@stevekmcc
Copy link

Since I wrote above in Aug 2016, two extra commits were added, and seem to have broken this (and streamlink). I've updated my comment above.

@sbstp
Copy link
Contributor

sbstp commented Nov 20, 2016

@intact can you submit this PR against the streamlink repo?

@Feliperc02
Copy link

I'm brand new, how do I download livestream.pyc?

@intact
Copy link
Contributor Author

intact commented Mar 2, 2017

@Feliperc02 You can download and use livestream.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants